Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Add JUnit test for firestore plugin for startAfter with where clause #33007

Closed
rishabhrathod01 opened this issue Apr 29, 2024 · 0 comments · Fixed by #33294
Closed

[Task]: Add JUnit test for firestore plugin for startAfter with where clause #33007

rishabhrathod01 opened this issue Apr 29, 2024 · 0 comments · Fixed by #33294
Assignees
@rishabhrathod01
Labels
BE Coders Pod Issues related to users writing code to fetch and update data Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Issues related to a specific integration Task A simple Todo

Comments

@rishabhrathod01
Copy link
Contributor

SubTasks

The unit test should cover test cases for the change made in this PR #32912
@rishabhrathod01 rishabhrathod01 added Task A simple Todo Integrations Pod Issues related to a specific integration Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. labels Apr 29, 2024
@github-actions github-actions bot added the BE Coders Pod Issues related to users writing code to fetch and update data label Apr 29, 2024
@rishabhrathod01 rishabhrathod01 self-assigned this Apr 29, 2024
@rishabhrathod01 rishabhrathod01 mentioned this issue May 8, 2024
Merged
2 tasks
rishabhrathod01 added a commit that referenced this issue May 9, 2024
@rishabhrathod01
chore: Add test case for FireStorePlugin pagination using where clause (
a3429f9 
#33294)

## Description

Adding JUnit test case for firestore plugin pagination with where clause

Fixes #33007 

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9013682301>
> Commit: ea10b7b
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9013682301&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->






## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rishabhrathod01 rishabhrathod01

Labels
BE Coders Pod Issues related to users writing code to fetch and update data Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Pod Issues related to a specific integration Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Add test case for FireStorePlugin pagination using where clause appsmithorg/appsmith
1 participant
@rishabhrathod01