Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Theme and font resets when color is picked from full colour picker mode #31959

Closed
1 task done
ramsaptami opened this issue Mar 20, 2024 · 4 comments · Fixed by #32989
Closed
1 task done

[Bug]: Theme and font resets when color is picked from full colour picker mode #31959

ramsaptami opened this issue Mar 20, 2024 · 4 comments · Fixed by #32989
Labels
Anvil POD Issue related to Anvil project Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Verified When issue is retested post its fixed WDS team

Comments

@ramsaptami
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

When in dark mode, theme and font resets when color is picked from full colour picker mode

Steps To Reproduce

  1. Change theme to dark theme on an app on the latest anvil instance
  2. Now select a colour from the 'full colour picker mode' - observe the system reset to light mode
  3. Set dark theme again
  4. Now change the font - observe it reset to 'system default'

Public Sample App

No response

Environment

Deploy Preview

Severity

Medium (Frustrating UX)

Issue video log

https://www.loom.com/share/eeee59ece03647c4869af65d343b9990

Version

cloud
@ramsaptami ramsaptami added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage WDS team WDS - theming labels Mar 20, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Deploy Preview Issues found in Deploy Preview Medium Issues that frustrate users due to poor UX labels Mar 20, 2024
@github-actions github-actions bot added Anvil POD Issue related to Anvil project labels Mar 20, 2024
@Nikhil-Nandagopal
Copy link
Contributor

Closing this as it does not have an appropriate label associated with a pod

@ramsaptami
Copy link
Contributor Author

Correct label has already been added & pod assignment has been made by the bot

@ramsaptami ramsaptami reopened this Mar 20, 2024
@KelvinOm KelvinOm removed Community Reported issues reported by community members Needs Triaging Needs attention from maintainers to triage Deploy Preview Issues found in Deploy Preview Anvil - theming labels Mar 27, 2024
@andreevanatasha andreevanatasha added High This issue blocks a user from building or impacts a lot of users and removed Medium Issues that frustrate users due to poor UX labels Apr 1, 2024
@jsartisan jsartisan mentioned this issue Apr 29, 2024
Merged
@somangshu
Copy link
Contributor

@ramsaptami who should this be assigned?

@ramsaptami
Copy link
Contributor Author

it's been fixed by Pawan already, just needs to be merged and closed

KelvinOm pushed a commit that referenced this issue May 2, 2024
@jsartisan
fix: update custom color picker button (#32989)
4b8e76a 
Fixes #31959
Tiny UX update to the custom color picker button in WDS theme settings.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced the theme property pane to identify and display custom accent
colors differently.
- **Style Updates**
- Improved alignment and visual presentation of buttons and labels in
the theme property pane.
	- Added new styles for SVG paths to enhance visual clarity.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
@appsmith-bot appsmith-bot added the QA Needs QA attention label May 2, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label May 2, 2024
@ramsaptami ramsaptami added Verified When issue is retested post its fixed and removed QA Needs QA attention labels May 8, 2024
@github-actions github-actions bot removed the QA Pod Issues under the QA Pod label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Anvil POD Issue related to Anvil project Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Verified When issue is retested post its fixed WDS team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update custom color picker button appsmithorg/appsmith
6 participants
@Nikhil-Nandagopal @andreevanatasha @somangshu @KelvinOm @appsmith-bot @ramsaptami