Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Allow instance admin to configure OIDC connection name #25660

Closed
1 task done
geekyme-fsmk opened this issue Jul 25, 2023 · 4 comments · Fixed by #32979
Closed
1 task done

[Feature]: Allow instance admin to configure OIDC connection name #25660

geekyme-fsmk opened this issue Jul 25, 2023 · 4 comments · Fixed by #32979
Assignees
@infinitetrooper @ankitakinger @deepika-appsmith
Labels
Billing & Usage Pod Issues pertaining to licensing, billing and usage across self serve and enterprise customers Enhancement New feature or request Frontend This label marks the issue or pull request to reference client code QA Pod Issues under the QA Pod QA Needs QA attention SSO Issues, requests and enhancements around Single sign-on. Team Managers Pod Issues that team managers care about for the security and efficiency of their teams TM_BU The issues on Team Manager which needs to be taken up by Billing & Usage

Comments

@geekyme-fsmk
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Summary

Currently, configuring an OIDC connection for appsmith signin results in this text being shown:

Screenshot 2023-07-24 at 10 26 32 PM

Instead of just showing "Sign in with OIDC SSO", allow the instance admin to configure the text such as "Sign in with Google Login".

Why should this be worked on?

For users (especially non-technical ones) of this instance, it is not intuitive what OIDC means.
Fixing this could enhance the user experience.
@geekyme-fsmk geekyme-fsmk added the Enhancement New feature or request label Jul 25, 2023
@Nikhil-Nandagopal Nikhil-Nandagopal added the SSO Issues, requests and enhancements around Single sign-on. label Aug 1, 2023
@github-actions github-actions bot added the Team Managers Pod Issues that team managers care about for the security and efficiency of their teams label Aug 1, 2023
@infinitetrooper
Copy link
Contributor

infinitetrooper commented Aug 1, 2023 •
edited

@geekyme-fsmk - Thanks for raising this issue Shawn.

@hiteshjoshi @trishaanand - What do you think about the complexity of implementing this? The value makes sense to me as users can use their IdP (or) Tenant names instead of SAML and OIDC which most end users lack the context of.

@colin-precisionos
Copy link

I would like to see this as well as it's confusing for our users since they don't know what OIDC is. We use Microsoft ADD - since there's only a few options for providers, can you just hardcode Microsoft, Google, etc

@infinitetrooper infinitetrooper mentioned this issue Oct 18, 2023
Closed
1 task
@infinitetrooper
Copy link
Contributor

@deepikaappsmith - Let's discuss the complexity of this before the next sprint planning. The idea is to allow users to configure a keyword that can be used to replace OIDC/SAML. The final button text will read Sign in with #keyword, for example - Sign in with Active Directory (or) Sign in with One Login etc.

@colin-precisionos
Copy link

colin-precisionos commented Oct 18, 2023 •
edited

This sounds fine. The keyword can be set in the SSO config and default to OIDC or SAML

@deepikaappsmith deepikaappsmith added the Billing & Usage Pod Issues pertaining to licensing, billing and usage across self serve and enterprise customers label Nov 7, 2023
@github-actions github-actions bot removed the Billing & Usage Pod Issues pertaining to licensing, billing and usage across self serve and enterprise customers label Nov 7, 2023
@deepikaappsmith deepikaappsmith added the TM_BU The issues on Team Manager which needs to be taken up by Billing & Usage label Dec 22, 2023
@github-actions github-actions bot added the Billing & Usage Pod Issues pertaining to licensing, billing and usage across self serve and enterprise customers label Dec 22, 2023
@pranayagarwal96 pranayagarwal96 added the Frontend This label marks the issue or pull request to reference client code label Feb 29, 2024
@ankitakinger ankitakinger mentioned this issue Apr 26, 2024
Merged
2 tasks
@abhvsn abhvsn closed this as completed May 14, 2024
@appsmith-bot appsmith-bot added the QA Needs QA attention label May 14, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label May 14, 2024
@ankitakinger ankitakinger reopened this May 14, 2024
ankitakinger added a commit that referenced this issue May 15, 2024
@ankitakinger
chore: Updating the login button names for OIDC & SAML to get it from…
62ffaf8 
… tenant config (#32979)

## Description

Updating the login button names for OIDC & SAML to get it from tenant
config

Fixes [#25660](#25660)

## Automation

/ok-to-test tags="@tag.Settings"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9073688267>
> Commit: f8c0454
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9073688267&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Improved admin settings management by removing redundant data fetching
in the super user functionalities.

- **New Features**
- Enhanced third-party authentication by dynamically updating social
login button labels based on tenant configurations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@infinitetrooper infinitetrooper

@ankitakinger ankitakinger

@deepika-appsmith deepika-appsmith

Labels
Billing & Usage Pod Issues pertaining to licensing, billing and usage across self serve and enterprise customers Enhancement New feature or request Frontend This label marks the issue or pull request to reference client code QA Pod Issues under the QA Pod QA Needs QA attention SSO Issues, requests and enhancements around Single sign-on. Team Managers Pod Issues that team managers care about for the security and efficiency of their teams TM_BU The issues on Team Manager which needs to be taken up by Billing & Usage
Projects
None yet
Milestone
No milestone