Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow individual series stroke width #150

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AlexRoig
Copy link
Contributor

@AlexRoig AlexRoig commented Oct 5, 2022

Add the option to either set a fixed width for all lines (as always) or individually per series as an array of widths.

Some marshalling tricks were needed as the width property can either be an array or a number.

If both set, the width has preference over the array.

Bump version to 23.0.2

Resolves #149

… last N values with dashes indicating that the value might be a prediction like on the demo link:

https://apexcharts.com/javascript-chart-demos/line-charts/gradient/
- Bump JS version from 3.30.0 to 3.35.0 to make the feature available
- Update the wrapper to include the forecast configuration
- Update the ChartsBuilder and ApexCharts to include the property
- Update the LineChartExample to add forecast data points
Add the option to either set a fixed width for all lines (as always) or individually per series as an array of widths.

Some marshalling tricks were needed as the `width` property can either be an array or a number.

If both set, the width has preference over the array.

Bump version to 23.0.2
@TFyre
Copy link
Collaborator

TFyre commented Oct 11, 2022

How about handling this on the JS side?

For example: on java side, always set as array, then unwrap it on JS side (if required) when there is only 1 element?

@TFyre
Copy link
Collaborator

TFyre commented Oct 11, 2022

#145 is included in this PR, can you please remove it?

@AlexRoig
Copy link
Contributor Author

AlexRoig commented Oct 17, 2022

I've removed the dependencies of #145.

I don't see how handling it on the JS side would help and I think it'd make things more complicated. The problem is that ApexCharts API is somehow confusing and having a variable that can either be a number or an array is not easy to handle on Java.

Moreover, creating a a single element array could create some issues when you want to set only the first element width different than default because from the JS side it's not the same width = 1 than width = [1].

@appreciated
Copy link
Owner

How about this issue? Can this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to create lines with different stroke
3 participants