Fix orennayarbrdf.cpp: no longer try to normalizes zero vectors. #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t are potentially zero vectors. Calculate the norm of each vector first and do an early return if zero. This avoids asserts in debug mode and divisions by null in release mode.
|
Thanks for your contribution @andreasdeclercq !
Can you please explain in which case you get divisions by null ? That would be great if you could provide a scene so that we can test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate the norm of each vector first and do an early return if zero.
This avoids asserts in debug mode and divisions by null in release mode.