Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview post-processing stage changes in appleseed.studio #2885

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

laurelkeys
Copy link
Contributor

@laurelkeys laurelkeys commented Aug 6, 2020

This adds a rendered preview when parameter values are changed for post-processing stages (similar to the current behavior of False Colors).

Note that only the effect that is being changed is applied for preview (i.e. if there are multiple stages, this won't show all of them).

gS09PO8IEs


Obs.: as of right now, when you add a new effect it doesn't work untill you click OK to add it and then edit its parameters. This should be fixed before this PR is merged.


Other "nice-to-have"s are:

  • Render effects preview on a downscaled version of the frame, so it's more responsive (and make this a customizable option)
  • Some way to "opt-out" of this (e.g. a checkbox), either for all stages or for a specific one, untill all effects are "real-time"
  • Save / export the current frame, with effects preview (should probably be an optional "pop-up")

@oktomus
Copy link
Member

oktomus commented Sep 28, 2020

Franz and I just tested your PR. Amazing work !

We are concerned about the processing time taken by the bloom effect or other future resource-intensive effect. I think we already discussed about this, but maybe you can add a checkbox to control the preview ? Like the following :

image

That checkbox won't be visible when first adding the effect, as the preview doesn't work there.

@oktomus oktomus marked this pull request as ready for review September 28, 2020 19:25
@oktomus oktomus marked this pull request as draft October 5, 2020 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants