Adapt C++ examples to recent changes in appleseed #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was it already black before ? |
|
I haven't run this example before so I cannot say with certainty. But I doubt the black part is correct. Looks like a bug. |
|
Thanks! It wasn't black before. This almost certainly is a self-intersection issue: |
dictoon
requested changes
Dec 27, 2019
| @@ -151,6 +151,13 @@ namespace | |||
| return raymarch(ray, t, p); | |||
| } | |||
|
|
|||
| void refine_and_offset( | |||
| const foundation::Ray3d& obj_inst_ray, | |||
| asf::hash_uint64(asf::binary_cast<asf::uint64>(ray.m_dir.x)) ^ | ||
| asf::hash_uint64(asf::binary_cast<asf::uint64>(ray.m_dir.y)) ^ | ||
| asf::hash_uint64(asf::binary_cast<asf::uint64>(ray.m_dir.z))); | ||
| asf::hash_uint64(asf::binary_cast<uint64_t>(ray.m_org.x)) ^ |
There was a problem hiding this comment.
Prefix integral types with std::.
|
Now that appleseed has a built-in sphere object, the sphere object plugin is kind of redundant even though it's a nice, simple example of how to write an object plugin (but maybe we could implement another shape). Anyway, you could have a look at how the built-in sphere object implements refining if you want to fix the sphere object plugin: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow building of the example files though I'm not sure it is the most elegant way to do it (adding the override).
Also there is still an issue with parts of the objects appearing black when rendering (see screenshot of sphereobject)