Variance tracking framebuffer (Path Guiding PR split) #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split from PR appleseedhq#2656 with variance estimation fix to keep reviews small. Contains the added VarianceTrackingShadingResultFramebuffer and matching factory, which keep track of the sum of squared samples to allow per pixel variance estimation. Also adapted the ishadingresultframebufferfactory interface and derived classes to allow dynamic calls to the get_total_channel_count() method for checkpoints.
Variance estimation is now calculating an estimate for the variance of the pixel value estimator instead of an estimate for the variance of the radiance distribution of incoming samples. Rename methods to reflect this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from PR #2656 (with added variance estimation fix) to keep reviews small.
Contains the added VarianceTrackingShadingResultFramebuffer and matching
factory, which keep track of the sum of squared samples to allow per
pixel variance estimation. The variance() and variance_image() methods allow
estimating the variance of the entire frame and writing the per pixel variance
to an output image.
Also adapted the ishadingresultframebufferfactory interface and derived
classes to allow dynamic calls to the get_total_channel_count() method
for checkpoints creation.