Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WASM] [BuildScript] Initial Support for building WASI toolchain #29465

Closed
wants to merge 1 commit into from
Closed

[WASM] [BuildScript] Initial Support for building WASI toolchain #29465

wants to merge 1 commit into from

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Jan 27, 2020 •
edited

This PR adds WASI toolchain variant to port our WebAssembly support, step by step.

This is a part of SR-9307 and #24684.

compnerd
compnerd requested changes Jan 27, 2020
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
cmake/modules/SwiftConfigureSDK.cmake Outdated Show resolved Hide resolved
@kateinoigakukun kateinoigakukun force-pushed the katei/swasm/build-script branch 2 times, most recently from fb2d12b to cc75c28 Compare January 27, 2020 06:41
@kateinoigakukun
Copy link
Member Author

Does this work conflict your recent work @compnerd ?

@compnerd
Copy link
Collaborator

@kateinoigakukun yes, it does. Also, please don't create large stacks of commits in a single PR, it makes it more difficult to review.

@kateinoigakukun
Copy link
Member Author

@compnerd OK, I fixed up them in 1 commit

@MaxDesiatov
Copy link
Member

Hi @compnerd, would you be able to have another look at this PR? Thank you and much appreciated!

@MaxDesiatov MaxDesiatov mentioned this pull request Feb 13, 2020
Closed
@MaxDesiatov
Copy link
Member

Hi @gribozavr @CodaFi would you be able to help with reviewing this PR? Or could you redirect to someone else more appropriate? Thank you 🙏

@MaxDesiatov MaxDesiatov mentioned this pull request Feb 17, 2020
Closed
78 tasks
@gribozavr
Copy link
Collaborator

The changes look good to me, but since I haven't touched the build system in a couple of years, I don't think my review in this area counts much. @compnerd ?

compnerd
compnerd reviewed Feb 17, 2020
View reviewed changes
Copy link
Collaborator

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s some more adjustments still needed I think.

utils/build-script-impl Outdated Show resolved Hide resolved
utils/build-script-impl Outdated Show resolved Hide resolved
utils/wasi/build-toolchain Outdated Show resolved Hide resolved
@kateinoigakukun kateinoigakukun force-pushed the katei/swasm/build-script branch 3 times, most recently from 09e952d to 047ab39 Compare February 18, 2020 07:21
@kateinoigakukun
Copy link
Member Author

@compnerd I minimized build-script related changes and changed to pass some options through extra-cmake-options directly temporarily to avoid conflicts.

@MaxDesiatov MaxDesiatov mentioned this pull request May 9, 2020
Merged
patcheng
patcheng reviewed May 12, 2020
View reviewed changes
utils/build-script-impl
@@ -153,6 +153,7 @@ KNOWN_SETTINGS=(
skip-test-osx "" "set to skip testing Swift stdlibs for OS X"
skip-test-tvos-host "" "set to skip testing the host parts of the tvOS toolchain"
skip-test-tvos-simulator "" "set to skip testing Swift stdlibs for tvOS simulators (i.e. test devices only)"
skip-test-wasi "" "set to skip testing Swift stdlibs for WebAssembly/WASI"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be a matching skip-build-wasi somewhere as well?

@MaxDesiatov MaxDesiatov changed the base branch from master to main September 24, 2020 08:53
@kateinoigakukun
Copy link
Member Author

We've already merged a lot of parts in this PR step by step, so close now

@kateinoigakukun kateinoigakukun deleted the katei/swasm/build-script branch June 10, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd requested changes

@MaxDesiatov MaxDesiatov MaxDesiatov left review comments

@patcheng patcheng patcheng left review comments

@karwa karwa karwa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kateinoigakukun @compnerd @MaxDesiatov @gribozavr @patcheng @karwa