WebAssembly Support #2640
Merged
WebAssembly Support #2640
+27
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aciidgh
reviewed
Mar 5, 2020
|
LGTM, thank you for working on this! I just have one minor comment about the availability of the new API. |
|
@aciidb0mb3r Thanks for your review! I updated that point. |
|
@swift-ci smoke test |
aciidgh
approved these changes
Mar 6, 2020
|
Sorry, I fixed test cases to fit this change 🙏 |
|
@swift-ci smoke test |
|
I'm not sure why the smoke test on Linux failed 🤔 |
|
@swift-ci smoke test linux |
|
Passed 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For wasm target, swift-autolink-extract try to extract info from swiftmodule. But without target argument, compiler emits module as Mach-O format on macOS which is not supported by swift-autolink-extract. So SwiftPM need to pass target option when emitting swiftmodule.
This is a part of SR-9307 and #24684.