Switch to using UnsafeContinuations in NIOAsyncWriter and NIOAsyncSequenceProducer
#2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation The current `NIOAsyncWriter` implementation expects that the delegate is called while holding the lock to avoid reentrancy issues. However, this prevents us from executing the delegate calls directly on the `EventLoop` if we are on it already. # Modification This moves all of the delegate calls outside of the locks. # Result Less allocations.
…ncSequenceProducer` # Motivation During the performance testing of the `NIOAsyncChannel` we saw most of the remaining allocations due to the usage of `CheckedContinuation`. We knew from the beginning that this might be something that we want to revisit down the line. # Modification This PR changes from `CheckedContinuation`s to `UnsafeContination`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During the performance testing of the
NIOAsyncChannelwe saw most of the remaining allocations due to the usage ofCheckedContinuation. We knew from the beginning that this might be something that we want to revisit down the line.Modification
This PR changes from
CheckedContinuations toUnsafeContination.