Add Timer.measure methods
#140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation This PR supersedes #135. The goal is to make it easier to measure asynchronous code when using `Metrics`. # Modification This PR does: - Deprecate the current static method for measuring synchronous code - Add a new instance method to measure synchronous code - Add a new instance method to measure asynchronous code # Result It is now easier to measure asynchronous code.
|
@swift-server-bot test this please |
Lukasa
approved these changes
Apr 22, 2024
|
@swift-server-bot add to allowlist |
fabianfett
approved these changes
Apr 22, 2024
gjcairo
approved these changes
Apr 22, 2024
| return try body() | ||
| } | ||
|
|
||
| /// Convenience for measuring duration of a closure with a provided clock. |
There was a problem hiding this comment.
Nit: the doc for this method and the non-async version don't match. Maybe remove the last bit to match that one, since we're defaulting the clock param anyways?
Suggested change
| /// Convenience for measuring duration of a closure with a provided clock. | |
| /// Convenience for measuring duration of a closure. |
|
@swift-server-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR supersedes #135. The goal is to make it easier to measure asynchronous code when using
Metrics.Modification
This PR does: