Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add byte order utilities #4792

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add byte order utilities #4792

wants to merge 2 commits into from

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Jul 8, 2023

@compnerd
Copy link
Collaborator

@swift-ci please test

compnerd
compnerd reviewed Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some unit tests for these please?

@woxtu
Copy link
Contributor Author

woxtu commented Jul 14, 2023

I tried to add unit tests.

@compnerd
Copy link
Collaborator

@swift-ci please test

@compnerd
Copy link
Collaborator

@swift-ci please test macOS platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@woxtu @compnerd