[HashTreeCollections] Add TreeDictionary.combining(_:by:)
#246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorentey
added
the
HashTreeCollections
Spin off two separate combining behaviors for values that are present in both dictionaries, based on whether or not the values are equal. Before this change, unequal values were always merged, which isn’t necessarily what we want.
|
Rescheduling to 1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an elaborate new entry point for structurally combining two
TreeDictionaryinstances, complete with a deeply customizable element-wise combining strategy.This PR is a proof of concept that may turn into a shipping feature. It currently builds, but it has not yet seen any testing whatsoever. The new APIs currently require Swift 5.7 or better, as they use primary associated types.
Checklist