Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for copy_ op #957 #962

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

vidursatija
Copy link
Contributor

This is the test for the torch copy_ op from #918

@TobyRoseman
Copy link
Collaborator

Rebased change and kicked off a CI run: https://gitlab.com/coremltools1/coremltools/-/pipelines/630204718

@TobyRoseman
Copy link
Collaborator

@@ -4759,3 +4759,14 @@ def forward(self, x):
backend=backend,
converter_input_type=converter_input_type,
)


class TestCopy:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be class TestCopy(TorchBaseTest):.

heydavid525
heydavid525 previously approved these changes Nov 1, 2022
Copy link

@heydavid525 heydavid525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides Toby's comment.

@TobyRoseman
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants