Lightgbm #254
Open
Lightgbm #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobyRoseman
reviewed
Oct 8, 2018
TobyRoseman
reviewed
Oct 8, 2018
|
Thanks for the pull request @calebmadrigal. Have you tested this in both Python 2.7 and either 3.5 or 3.6? |
|
@TobyRoseman I've only tested on python 3.6. |
|
@TobyRoseman I tested on Python 2.7, and fixed a couple incompatibilities. So at this point, it is tested on python 2.7 and 3.6. |
|
Is there anything missing/outstanding that I can help with to get this PR merged? |
srikris
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds LightGBM support to CoreML Tools, and supports both Classifiers (Binary and Multiclass) and Regressors.