feat: implement search context and UA based on selenium 4.21 #480
+172
−278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
changed the title
KazuCocoa
commented
Feb 3, 2024
|
ok, anyway this implementation works. |
KazuCocoa
commented
Feb 3, 2024
Comment on lines
40
to
43
| # def available_contexts | ||
| # # return empty array instead of nil on failure | ||
| # execute(:available_contexts, {}) || [] | ||
| # end |
There was a problem hiding this comment.
this comment out is to test add_command
KazuCocoa
commented
Feb 4, 2024
Comment on lines
+177
to
+179
| # def add_command(method:, url:, name:, &block) | ||
| # Bridge.add_command name, method, url, &block | ||
| # end |
There was a problem hiding this comment.
todo: once we move to this bridge.add_command, need to update tests as well. should be another pr
KazuCocoa
commented
Feb 4, 2024
KazuCocoa
changed the title
KazuCocoa
changed the title
KazuCocoa
changed the title
KazuCocoa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to implement search context and UA based on SeleniumHQ/selenium#12141