Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mobile:webInspector to send webinspector command #1619

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KazuCocoa
Copy link
Member

Instead of #1455

I haven't tested yet, but I'd like to do somehing laster:

  • Animation.enable,Animation.disable
  • ApplicationCache.enable,ApplicationCache.disable
  • DOMStorage.enable, DOMStorage.disable
  • Memory.enable, Memory.disable
  • Network.setEmulatedConditions

Perhaps this pr needs to have some documentation with a couple of example code.

I'm thinking to add this command to send some of webinspector commands
https://github.com/appium/appium-remote-debugger/blob/717a6310dba7ccf14db8aeef28b8eac3d7f6abf9/lib/protocol/index.js

Maybe it does not work fully, so we may need to append more code, or need to update the remote debugger side such as https://github.com/appium/appium-remote-debugger/blob/717a6310dba7ccf14db8aeef28b8eac3d7f6abf9/lib/rpc/remote-messages.js#L13.

example usage:

# Ruby client
@driver.execute_script 'mobile:webInspector', {method: 'Page.reload'}

Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool idea! why call it 'web inspector' and not something more like 'sendRemoteDebugCommand'? i'm unclear what it has to do with the web inspector

@KazuCocoa
Copy link
Member Author

That was just picked from inspector https://github.com/WebKit/WebKit/tree/main/Source/JavaScriptCore/inspector and the directory's commits had Web Inspector. Can change the command naming anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants