Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the <pre> tags in the rich text widget so now line breaks inside <pre> tags will work #4362

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed the <pre> tags in the rich text widget so now line breaks inside <pre> tags will work #4362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions modules/@apostrophecms/rich-text-widget/index.js
View file
Open in desktop
Expand Up @@ -335,8 +335,11 @@ module.exports = {
optionsToSanitizeHtml(options) {
return {
...sanitizeHtml.defaults,
allowedTags: self.toolbarToAllowedTags(options),
allowedAttributes: self.toolbarToAllowedAttributes(options),
allowedTags: [...self.toolbarToAllowedTags(options), 'pre'],
allowedAttributes: {
...self.toolbarToAllowedAttributes(options),
'pre': ['*']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a change to allowed attributes is needed it should be added to toolbarToAllowedAttributes rather than being merged in afterward.

However allowing all attributes is a security issue, and I also don't understand why allowing all attributes would help with line breaks.

Can you clarify the reasoning behind this code?

},
allowedClasses: self.toolbarToAllowedClasses(options),
allowedStyles: self.toolbarToAllowedStyles(options)
};
Expand Down