Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter the fetches we add to a batch when we create the batch #5034

Merged
merged 3 commits into from Apr 30, 2024

Conversation

garypen
Copy link
Contributor

@garypen garypen commented Apr 26, 2024

Without filtering the query hashes during batch creation we could end up in a situation where we have additional query hashes in the batch.

This manifests itself by batch queries failing with query hashes appearing as committed without ever having been registered in a batch.

Filtering during batch creation is now matching the filtering at subgraph coordination.

Without filtering the query hashes during batch creation we could end up
in a situation where we have additional query hashes in the batch.

This manifests itself by batch queries failing with query hashes
appearing as committed without ever having been registered in a batch.

Filtering during batch creation is now matching the filtering at
subgraph coordination.
@garypen garypen self-assigned this Apr 26, 2024

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Apr 26, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • no-graphos - Basic stress test, no GraphOS.
  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • const - Basic stress test that runs with a constant number of users

@garypen garypen merged commit d69e30d into dev Apr 30, 2024
14 checks passed
@garypen garypen deleted the garypen/ROUTER-243/batch-fetch-filter branch April 30, 2024 09:01
BrynCooke pushed a commit that referenced this pull request May 3, 2024
Without filtering the query hashes during batch creation we could end up
in a situation where we have additional query hashes in the batch.

This manifests itself by batch queries failing with query hashes
appearing as committed without ever having been registered in a batch.

Filtering during batch creation is now matching the filtering at
subgraph coordination.
@BrynCooke BrynCooke mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants