Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(maint): Update code and snapshots after proto update #5026

Closed
wants to merge 6 commits into from

Conversation

bonnici
Copy link
Contributor

@bonnici bonnici commented Apr 26, 2024

Updates code and snapshots so that we store default values in the new proto fields.

@router-perf
Copy link

router-perf bot commented Apr 26, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • no-graphos - Basic stress test, no GraphOS.
  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • const - Basic stress test that runs with a constant number of users

@abernix abernix enabled auto-merge (squash) April 26, 2024 06:01
@abernix abernix changed the title Update code and snapshots after proto update chore(maint): Update code and snapshots after proto update Apr 26, 2024
auto-merge was automatically disabled April 26, 2024 06:04

Head branch was pushed to by a user without write access

@abernix abernix enabled auto-merge (squash) April 26, 2024 06:09
auto-merge was automatically disabled April 26, 2024 06:17

Head branch was pushed to by a user without write access

@abernix
Copy link
Member

abernix commented Apr 26, 2024

I've opened up #5029 to land this on 1.45.1. I'll also note that we've introduced #5031 and #5030 to remove the "proto has changed? here, have a failing dev branch to go with that" behavior, which should hopefully make it way less necessary for you to time your contributions to this repository and mostly just require that you wait until the next "5 minute" interval and find the chore Update Apollo Protobuf PR like the one referenced above.

@abernix
Copy link
Member

abernix commented Apr 26, 2024

For whatever reason, this landed cleanly and passed CI on #5029 — which targeted 1.45.1, whereas tests are refusing to pass on this PR. I'm unable to tell why.

@abernix
Copy link
Member

abernix commented May 3, 2024

Superseded by #5032, which did work and land. Best guess is CI cache is just busted on this PR because of underlying issues that existed on dev on the day it was built.

@abernix abernix closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants