Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure subgraph requests have access to their corresponding ExecutableDocuments #5016

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

tninesling
Copy link
Contributor

When we apply demand control measurements, we want to measure the cost of an operation at several points. We score the overall operation, the query plan, and each subgraph operation. In order to score these operations, we need to use an ExecutableDocument, which is already provided for the top-level operation but not for the subgraph requests.

In order to achieve this, we could store the ExecutableDocument on each subgraph request. However, this defeats the purpose of having the fetch nodes lazily initialize the documents (and breaks a bunch of query planner tests because they are lacking appropriate subgraph schemas in their setup). To avoid having to define subgraph schemas for all these tests and to preserve the lazy initialization setup, I instead embed a reference to the fetch node that is creating the subgraph request, which can trigger the lazy init when it is being executed.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

Copy link
Contributor

@tninesling, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Apr 24, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • no-graphos - Basic stress test, no GraphOS.
  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • const - Basic stress test that runs with a constant number of users

@tninesling tninesling closed this Apr 24, 2024
@tninesling tninesling reopened this Apr 25, 2024
BrynCooke
BrynCooke previously approved these changes May 15, 2024
@BrynCooke BrynCooke dismissed their stale review May 15, 2024 11:54

Noticed an issue

Copy link
Contributor

@BrynCooke BrynCooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some tests for the new code in the demand control plugin.

.as_parsed(schema)
.map_err(DemandControlError::from)
})
.expect("must have a valid query")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should convert to an error here rather than using expect. DemandControlError::QueryParseFailure could be reused, or we could add something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants