Added long to peer dependencies #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map field TypeScript types shouldn't imply all keys exist
Merged
glasser
force-pushed
the
master
branch
2 times, most recently
from
16ecc2d
to
0473ffb
Compare
|
We don't actually use Long the way we set it up in apollo-protobuf-reporting. We should probably just remove Long entirely from generated code. |
|
Ah like in #7! Looking at that instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protobuf.js/cli/pbts.js
Line 155 in 757f6e3
longis included in the emitted (TypeScript) code and so should be a peer dependency.