Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow @sourceField on fields of object types _and_ type extensions. #2925

Open
wants to merge 1 commit into
base: benjamn/fix-specs-module-load-order
Choose a base branch
from
Open

Allow @sourceField on fields of object types _and_ type extensions. #2925

wants to merge 1 commit into from

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Feb 1, 2024

This fixes (and regression-tests) a spurious validation error introduced by my PR #2910.

@benjamn benjamn self-assigned this Feb 1, 2024
@benjamn benjamn requested a review from a team as a code owner February 1, 2024 22:53
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2024 •
edited

⚠️ No Changeset found

Latest commit: 21bea79

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Feb 1, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@benjamn benjamn force-pushed the benjamn/fix-@sourceField-validation-on-extend-type branch from 693ff67 to 21bea79 Compare February 1, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lennyburdette lennyburdette lennyburdette approved these changes

@dariuszkuc dariuszkuc dariuszkuc approved these changes

@clenfest clenfest Awaiting requested review from clenfest

Assignees

@benjamn benjamn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benjamn @lennyburdette @dariuszkuc