reduce the number of pruning operations

[Geal]

Instead of checking a path against the entire list of paths every time, we only check against the list of already accepted paths.

[changeset-bot]

⚠️ No Changeset found

Latest commit: f8e7b10

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for apollo-federation-docs canceled.

Name	Link
🔨 Latest commit	f8e7b10
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-federation-docs/deploys/6571ac1723196400095960aa

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[Geal]

there's another potnetial optimization here: makingownPathIds a Set instead of an array:

federation/query-graphs-js/src/graphPath.ts

Line 153 in 3f7392b

readonly ownPathIds: readonly string[],

Since it is only used to be filled and the only part where it is read is in isOverridenBy`:

federation/query-graphs-js/src/graphPath.ts

Lines 770 to 777 in 3f7392b

	isOverriddenBy(otherPath: GraphPath<TTrigger, RV, TNullEdge>): boolean {
	for (const overriddingId of this.props.overriddingPathIds) {
	if (otherPath.props.ownPathIds.includes(overriddingId)) {
	return true;
	}
	}
	return false;
	}

[Geal]

I am not sure this PR is correct. In markOverriding:

federation/query-graphs-js/src/graphPath.ts

Lines 753 to 768 in 3f7392b

	markOverridding(otherOptions: GraphPath<TTrigger, RV, TNullEdge>[][]): {
	thisPath: GraphPath<TTrigger, RV, TNullEdge>,
	otherOptions: GraphPath<TTrigger, RV, TNullEdge>[][],
	} {
	const newId = uuidv4();
	return {
	thisPath: new GraphPath({
	...this.props,
	ownPathIds: this.props.ownPathIds.concat(newId),
	}),
	otherOptions: otherOptions.map((paths) => paths.map((p) => new GraphPath({
	...p.props,
	overriddingPathIds: p.props.overriddingPathIds.concat(newId),
	}))),
	};
	}

we add the newId to thisPath.ownPathIds but we add it to overridingPathIds in the paths under otherOptions. So I don't think there's a transitive dependency here where A overrides B and B overrides C would mean A overrides C