Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify primary key terminology for @key #2796

Merged
merged 8 commits into from
Oct 3, 2023
Merged

Clarify primary key terminology for @key #2796

merged 8 commits into from
Oct 3, 2023

Conversation

Meschreiber
Copy link
Contributor

Addresses #2795

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2023 •
edited

⚠️ No Changeset found

Latest commit: 4339fd5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Sep 29, 2023 •
edited

✅ Deploy Preview for apollo-federation-docs ready!

Name Link
🔨 Latest commit 4339fd5
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/651b585d0fa0380008a40b62
😎 Deploy Preview https://deploy-preview-2796--apollo-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Meschreiber Meschreiber changed the title Docs/remove pk language Clarify primary key terminology for @key Sep 29, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 29, 2023 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Meschreiber Meschreiber marked this pull request as ready for review September 29, 2023 08:34
@Meschreiber Meschreiber requested a review from a team as a code owner September 29, 2023 08:35
trevor-scheer
trevor-scheer approved these changes Sep 29, 2023
View reviewed changes
docs/source/entities.mdx Outdated Show resolved Hide resolved
docs/source/entities.mdx Outdated Show resolved Hide resolved
docs/source/federated-types/federated-directives.mdx Show resolved Hide resolved
shorgi
shorgi approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@shorgi shorgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy LGTM, with one comment

@Meschreiber Meschreiber merged commit c62be95 into main Oct 3, 2023
14 of 15 checks passed
@Meschreiber Meschreiber deleted the docs/remove-pk-language branch October 3, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevor-scheer trevor-scheer trevor-scheer approved these changes

@shorgi shorgi shorgi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Meschreiber @shorgi @trevor-scheer