Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "primary key" language #2795

Open
trevor-scheer opened this issue Sep 28, 2023 · 0 comments
Open

Remove "primary key" language #2795

trevor-scheer opened this issue Sep 28, 2023 · 0 comments
Assignees

Comments

@trevor-scheer
Copy link
Member

We refer to @keys as "primary keys" in various places, but @key doesn't align well with the actual definition of a PK so it's a misnomer that might add confusion. We allow multiple keys and varying keys on the same entity from one subgraph to another, whereas there can only be one PK in a database context. In most cases @key will be used as a PK so it can be helpful to build the mental model but it should be clear that that isn't a constraint that @key is bound to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants