This repository has been archived by the owner on May 3, 2024. It is now read-only.
Draft WASM validation logic #269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholascioli
requested review from
dariuszkuc,
sachindshinde,
goto-bus-stop and
SimonSapin
as code owners
lennyburdette
approved these changes
Apr 23, 2024
| } | ||
|
|
||
| // First we need to create an actul schema from the provided one | ||
| let schema = apollo_compiler::Schema::parse(subgraph_schema, "") |
There was a problem hiding this comment.
we can use parse_and_validate i think
| // Process the @source directives | ||
| let sources = schema | ||
| .referencers() | ||
| .get_directive(&SOURCE_DIRECTIVE_NAME_IN_SPEC) |
There was a problem hiding this comment.
this will error if it can't find any sources — before we do anything, we should first check to see if the @link is present using schema.metadata() (and return early if it's not), and we should ignore the Err case for sources since they're optional.
|
This is no longer needed, as it is out of date and will be made anew. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a partial implementation of validation of a string schema, which will be useful in WASM contexts where operating on Rust types does not work.
This implementation is partial as it can still trigger a panic if a directive is invalid.