protobufjs that doesn't generate Long import in .t.ds

See apollographql/protobuf.js#7 A future version could fully remove Long support from our fork but we aren't quite there yet.
apollographql · Apr 29, 2021 · 6d3be40 · 6d3be40
1 parent 3415b07
commit 6d3be40
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 30 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/apollo-reporting-protobuf/package.json b/packages/apollo-reporting-protobuf/package.json
@@ -29,6 +29,6 @@
   },
   "homepage": "https://github.com/apollographql/apollo-server#readme",
   "dependencies": {
-    "@apollo/protobufjs": "1.2.0"
+    "@apollo/protobufjs": "1.2.1"
   }
 }
diff --git a/packages/apollo-reporting-protobuf/src/index.js b/packages/apollo-reporting-protobuf/src/index.js
@@ -3,7 +3,8 @@ const protobufJS = require('@apollo/protobufjs/minimal');
 
 // Remove Long support.  Our uint64s tend to be small (less
 // than 104 days).
-// XXX Just remove this in our fork?
+// XXX Just remove this in our fork? We already deleted
+// the generation of Long in protobuf.d.ts in the fork.
 // https://github.com/protobufjs/protobuf.js/issues/1253
 protobufJS.util.Long = undefined;
 protobufJS.configure();