Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SECOPS-2268: Add Gitleaks to CI #3254

Merged
merged 1 commit into from
Oct 12, 2023
Merged

SECOPS-2268: Add Gitleaks to CI #3254

merged 1 commit into from
Oct 12, 2023

Conversation

svc-secops
Copy link
Contributor

Motivation / Implements

This PR adds the necessary files to configure Gitleaks to run on PRs on this repo. The Apollo Security team uses Gitleaks to test our repositories for secrets.

Once this is accepted and merged, the Security team plans to make a passing Gitleaks check a requirement for PRs to merge into this repo. This will prevent secrets from being introduced to our repos.

In the event that a secret is detected on a repo, the CI job will add a comment to the PR associated with the detection to provide instructions on how to properly resolve the detection. Additionally, if a secret is detected, the Apollo Security team will be notified so that we can be available to assist in resolving the detection.

If maintainers reviewing this PR have questions, please see this Apollo-internal Slack link.

Changed

  • Added .circleci/config.yml to this repo. This file contains appropriate configuration to enable Gitleaks as a CI check.

@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for apollo-ios-docs failed.

Name Link
🔨 Latest commit 237b650
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docs/deploys/6526b4c2069f0d00084b2394

@github-actions
Copy link

We do not accept PRs directly to the 'apollo-ios' repo. All development is done through the 'apollo-ios-dev' repo, please see the CONTRIBUTING guide for more information.

@github-actions github-actions bot closed this Oct 11, 2023
@calvincestari calvincestari reopened this Oct 12, 2023
@calvincestari calvincestari marked this pull request as ready for review October 12, 2023 21:27
@calvincestari calvincestari merged commit 743a2cb into main Oct 12, 2023
3 of 7 checks passed
@calvincestari calvincestari deleted the secops/add-gitleaks branch October 12, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants