fix: Remove empty arrays from privacy manifests #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
✅ Deploy Preview for apollo-ios-docc canceled.
|
AnthonyMDev
approved these changes
Mar 22, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Mar 22, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Mar 22, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Mar 22, 2024
4e716cd8 fix: Remove empty arrays from privacy manifests (#309) git-subtree-dir: apollo-ios git-subtree-split: 4e716cd8808a9f4bf666d1e4bcf296f5bc838a04
BobaFetters
pushed a commit
that referenced
this pull request
Mar 22, 2024
…anifests git-subtree-dir: apollo-ios git-subtree-mainline: 500557c git-subtree-split: 4e716cd8808a9f4bf666d1e4bcf296f5bc838a04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apollographql/apollo-ios#3359.
I re-read Apple's privacy manifest files documentation and it looked like we were declaring arrays but not completing them correctly. This appears to be what made the manifests appear invalid. This change is simply to remove those arrays, leaving the parent keys empty.