[ApolloPagination] Add completion callbacks to fetch and refetch in GraphQLQueryPager for API Consistency #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-ios-docc pending review.Visit the deploys page to approve it
|
👷 Deploy request for eclectic-pie-88a2ba pending review.Visit the deploys page to approve it
|
Iron-Ham
changed the title
AnthonyMDev
approved these changes
Mar 12, 2024
We probably should re-generate the docset, yeah. But since this is a non-breaking change, I can see an argument for a 0.1.1. EDIT: 0.2.0 is probably the right move, given that there's a PR up with a breaking change: #299 |
Iron-Ham
force-pushed
the
hs/add-callbacks
branch
from
a183b6e
to
3e77136
Compare
This was referenced Mar 25, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Mar 25, 2024
…raphQLQueryPager for API Consistency (#292)
BobaFetters
pushed a commit
to apollographql/apollo-ios-pagination
that referenced
this pull request
Mar 25, 2024
…raphQLQueryPager for API Consistency (apollographql/apollo-ios-dev#292)
BobaFetters
pushed a commit
that referenced
this pull request
Mar 25, 2024
d8ddfdbc [ApolloPagination] Add completion callbacks to fetch and refetch in GraphQLQueryPager for API Consistency (#292) git-subtree-dir: apollo-ios-pagination git-subtree-split: d8ddfdbc22d8cd1515a7e8288498e1056850d7f8
BobaFetters
pushed a commit
that referenced
this pull request
Mar 25, 2024
…etion callbacks to fetch and refetch in GraphQLQueryPager for API Consistency git-subtree-dir: apollo-ios-pagination git-subtree-mainline: e7ee41b git-subtree-split: d8ddfdbc22d8cd1515a7e8288498e1056850d7f8
|
SopheaSao Cambodia Enjoy with you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For API consistency, it makes sense that both
fetchandrefetchhave completion blocks to indicate when their operations are completed. If we think about the way that theAsyncvariant works, we always have a "completion" signal in the form of theawait– whereas we don't forfetchandrefetchin theGraphQLQueryPager.Related: apollographql/apollo-ios#3349
Changes in
GraphQLQueryPager.swift:public class GraphQLQueryPager<Model>: Publisher {: Therefetchandfetchmethods have been updated to include two new parameters:callbackQueueandcompletion. This allows users to specify a dispatch queue on which the completion callback should be fired and a completion block that triggers after the operation execution.Changes in
GraphQLQueryPagerCoordinator.swift:public protocol PagerType {: Therefetchandfetchmethods in thePagerTypeprotocol have been updated to include thecallbackQueueandcompletionparameters, aligning with the changes made in theGraphQLQueryPagerclass.class GraphQLQueryPagerCoordinator<InitialQuery: GraphQLQuery, PaginatedQuery: G: Therefetchandfetchmethods have been updated to include thecallbackQueueandcompletionparameters. This allows users to specify a dispatch queue on which the completion callback should be fired and a completion block that triggers after the operation execution. [1] [2]