Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update explainer around reducing-bundle-size #11791

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

smyrick
Copy link
Member

@smyrick smyrick commented Apr 18, 2024

I wrote this from an internal call. It was good insights that should be on our public docs

@smyrick smyrick requested a review from a team as a code owner April 18, 2024 22:02
Copy link

changeset-bot bot commented Apr 18, 2024

⚠️ No Changeset found

Latest commit: 9eed952

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 9eed952
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/663be3c7e03d10000867763f
😎 Deploy Preview https://deploy-preview-11791--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will hand this off to Maria, but I really like this addition!

## Why havev a larger library in the first place?

### What you get
Apollo Client is more than just a simple data fetcher: it is a request/response cache, state manager, and React component integration. Attempting to build a comparable experience to Apollo Client with other libraries would require you to write custom logic, libraries, and components wrappers. Scaling that out to all the components in your application would easily lead to a larger bundle and doing so with a custom and difficult to understand implementation that needs to be maintain by your team. By choosing Apollo Client, you hand off that ownership to a trusted team building Open Source Software since 2016.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! Only other thing I'd add to that list of what Apollo Client is is adding something about testing utilities as well. I think that is also an important part of the library and is definitely not something you will ever see in a production bundle.

docs/source/development-testing/reducing-bundle-size.mdx Outdated Show resolved Hide resolved
@jerelmiller
Copy link
Member

@Meschreiber when you get a chance, I'd love for you to take a look 🙂

Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
Copy link
Contributor

@Meschreiber Meschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this addition @smyrick and ping @jerelmiller ! Just some suggestions for conciseness.

docs/source/development-testing/reducing-bundle-size.mdx Outdated Show resolved Hide resolved
docs/source/development-testing/reducing-bundle-size.mdx Outdated Show resolved Hide resolved
docs/source/development-testing/reducing-bundle-size.mdx Outdated Show resolved Hide resolved
Co-authored-by: Maria Elisabeth Schreiber <maria.schreiber@apollographql.com>
Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then let's get this merged :)

@phryneas phryneas added the auto-cleanup 🤖 label Apr 22, 2024
@phryneas
Copy link
Member

Uh, it seems I can't push to this branch. Could you please run npm run format locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants