Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Data masking algorithm #11686

Draft
wants to merge 24 commits into
base: data-masking
Choose a base branch
from

Conversation

jerelmiller
Copy link
Member

This is FAR from done and not ready for any sort of formal review. Throwing this up there to be transparent about progress.

This is in a very rough state and is more of a brute force attempt at this stage. As I make progress, I'll layer in performance enhancements and additional things needed by this algorithm. All fragment data is currently lost when returning from the masking function which will be essential to the end-goal.

Copy link

changeset-bot bot commented Mar 14, 2024

⚠️ No Changeset found

Latest commit: dc91836

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@phryneas
Copy link
Member

Just out of interest - is there a reason you're not hooking into that as part of the cache, about here?

const fragment = getFragmentFromSelection(
selection,
context.lookupFragment
);
if (!fragment && selection.kind === Kind.FRAGMENT_SPREAD) {
throw newInvariantError(`No fragment named %s`, selection.name.value);
}
if (fragment && policies.fragmentMatches(fragment, typename)) {
fragment.selectionSet.selections.forEach(workSet.add, workSet);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants