Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Allow devtools to work with multiple client instances #1282

Draft
wants to merge 47 commits into
base: main
Choose a base branch
from
Draft

[WIP] Allow devtools to work with multiple client instances #1282

wants to merge 47 commits into from

Conversation

jerelmiller
Copy link
Member

No description provided.

@relativeci RelativeCI
Copy link

relativeci bot commented Mar 20, 2024 •
edited

Job #67: Bundle Size — 1.2MiB (+10.62%).

0763a0b(current) vs cc98a1e main#52(baseline)

Important

Bundle introduced 39 duplicate packages – View changed duplicate packages

Warning

Bundle introduced 24 new packages: serialize-error, @radix-ui/react-select, @radix-ui/number and 21 more – View changed packages

Bundle metrics  Change 7 changes Regression 4 regressions Improvement 1 improvement
                 Current
Job #67		      Baseline
Job #52
Regression  Initial JS 1.17MiB(+10.98%) 1.05MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 95.62% 0%
No change  Chunks 5 5
No change  Assets 12 12
Change  Modules 601(+21.91%) 493
Regression  Duplicate Modules 56(+51.35%) 37
Improvement  Duplicate Code 7.51%(-4.33%) 7.85%
Regression  Packages 122(+106.78%) 59
Regression  Duplicate Packages 43(+975%) 4
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #67		      Baseline
Job #52
Regression  JS 1.17MiB (+10.98%) 1.05MiB
Not changed  IMG 35.85KiB 35.85KiB
Not changed  HTML 810B 810B
Not changed  Other 777B 777B

View job #67 report View multiple-clients branch activity View project dashboard

@jerelmiller
Move createId to own utils file
0d8a2a2
@jerelmiller
Create and store id with client when registering it
fa25009
@jerelmiller
Show select when there are clients
859551a
@jerelmiller
Register id with client in known clients
e08179c
@jerelmiller
Extract client select into own component
c7137d7
@jerelmiller
Combine rpc messages into single type
d3d9fc2
@jerelmiller
Fix ts issue passing bad value
720dca5
@jerelmiller
Create type for apollo client info
edfd4f7
@jerelmiller
Send message when new client is registered
9383f2b
@jerelmiller
Add offset to differentiate queries in demo app
2494386
@jerelmiller
Move client select back to app
2875604
@jerelmiller
Send message where known client is set to prevent duplicate registration
c1eaf90
@jerelmiller
Add a way to watch for client to be destroyed
e4b3226
@jerelmiller
Handle when client is destroyed
8af0d24
@jerelmiller
Add button to terminate client
f1d5681
@jerelmiller
Send message when client is terminated
b965dcd
@jerelmiller
Rename destroyClient to terminateClient
e44fe05
@jerelmiller
Swap order of operations
0763a0b
Base automatically changed from better-error-serialization to main March 20, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jerelmiller