Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds format functionality #18

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Adds format functionality #18

wants to merge 9 commits into from

Conversation

1wheel
Copy link

@1wheel 1wheel commented May 20, 2021

Hey @j6k4m8, this package has been super useful. I sat down to add the ability save files #15 and ended up tweaking a bunch of things:

  • Adds a format function
  • Only expose the parse and format functions. This avoids the need for load error handling File failing to load.  #9; there's also not any need for the class wrapper.
  • Converts to a module so the same code can run in node or the browser without bundling.
  • parse throws errors if it encounters unsupported npy options
  • parse reads both bytes of header length and can handle files with larger headers
  • 2 spaces instead of 4 : p

That's a bunch of breaking changes—feel free to only grab the things you want!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant