Add path groups #37
Merged
Add path groups #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome!! Ready to merge? |
|
Ready from my end. I was hoping to get this into a new grandcypher release and require that version or greater when using it with txtai. This feature is going to enable this functionality: neuml/txtai#540 |
|
Groovy — will merge now! |
|
Actually — before I do... Any interest in adding yourself to the changelog to collect your internet points? Otherwise, I can do it after we merge :) |
|
Sure. I can push another commit with a change log update for 0.6.0. I'll also update setup.py. |
|
Just pushed the updated CHANGELOG and bumped version in setup.py |
j6k4m8
approved these changes
Feb 15, 2024
This was referenced Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of #26 as discussed in #35.
After thinking about how a standard node and relationship are returned, this initial implementation mirrors that for paths.
For example:
Returns:
With this change:
Returns:
[node id1, {relationship attributes} node id2]
The plumbing is now in place to return the data in whatever format we think makes sense.
I think I modified the lark spec to make the path_clause optional. The tests pass.