Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/synced cron #193

Merged
merged 3 commits into from Jul 2, 2015
Merged

Hotfix/synced cron #193

merged 3 commits into from Jul 2, 2015

Conversation

frenchbread
Copy link
Contributor

@apinf/developers , please review this hotfix.
Fixes:

  • Packages updates
  • Hostname for apiUmbrella analytics data now is http://46.101.247.242/ while apinf.com is down
  • SyncedCron requests frequency changed up to a call per 1 day (so that logs are not overflowing the terminal window)

55 pushed a commit that referenced this pull request Jul 2, 2015
Merge pull request #193 from apinf/hotfix/synced-cron
bd67a61 
Hotfix/synced cron
@55 55 merged commit bd67a61 into develop Jul 2, 2015
@55 55 removed the in progress label Jul 2, 2015
@55 55 deleted the hotfix/synced-cron branch July 2, 2015 05:37
@frenchbread frenchbread mentioned this pull request Jul 2, 2015
Closed
@brylie
Copy link
Contributor

brylie commented Jul 2, 2015

This pull request contains changes that aren't related to the SyncedCron hotfix. Specifically:

  • server/methods/elasticSearch.js changes are related to a different branch
  • server/methods/elasticSearch.js contains hard-coded server IP information that should not be included in this publicly available, open-source project.

Going forward, please make sure all modifications in any given pull request are relevant to the purpose of the pull request, and that specific server details are kept in configuration files.

@frenchbread
Copy link
Contributor Author

@brylie Pull request #198 contains fixes regarding this issues. Please, review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frenchbread @brylie @55