Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pipenv #54

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Switch to pipenv #54

merged 1 commit into from
Jan 23, 2019

Conversation

kylef
Copy link
Member

@kylef kylef commented Jan 23, 2019

I wanted to update some of the dependencies as GitHub mentions there are potential security problems with some versions are we are using:

screenshot 2019-01-23 at 14 59 01

It's a little tricky to manage the versions with requirements.txt locking so I though we'd move to Pipenv as we have in other places, pipenv support in readthedocs is coming soon (readthedocs/readthedocs.org#4783). I've managed to retain compatibility by creating a requirements.txt file from the Pipfile.lock (pipenv lock -r --dev > requirements.txt). Once pipenv support is available in RTD we can remove the requirements.txt and add a a configuration for pipfile:

diff --git a/.readthedocs.yml b/.readthedocs.yml
new file mode 100644
index 0000000..c112522
--- /dev/null
+++ b/.readthedocs.yml
@@ -0,0 +1,7 @@
+version: 2
+sphinx:
+  configuration: docs/conf.py
+python:
+  install:
+    - pipfile: .
+      dev: true

@honzajavorek
Copy link
Contributor

pipenv lock -r --dev > requirements.txt

I've been using https://github.com/gsemet/pipenv-to-requirements 😮

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Pipfile Show resolved Hide resolved
Pipfile Outdated Show resolved Hide resolved
@kylef kylef merged commit c558920 into master Jan 23, 2019
@kylef kylef deleted the kylef/pipenv branch January 23, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants