Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oas2): add format link #527

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(oas2): add format link #527

wants to merge 6 commits into from

Conversation

marcofriso
Copy link
Contributor

Closes APIARY-6105

@marcofriso marcofriso changed the title Marco/format link feat(oas2): add format link Aug 4, 2020
@marcofriso marcofriso requested a review from kylef August 4, 2020 11:55
@marcofriso marcofriso requested a review from kylef August 4, 2020 14:18
@marcofriso
Copy link
Contributor Author

marcofriso commented Aug 7, 2020

I had errors on the same tests locally today after I came back to this branch, I re-ran env GENERATE=1 npm test and now everything is passing again (locally).

The error was:

(node:42618) UnhandledPromiseRejectionWarning: AssertionError: expected { Object (element, meta, ...) } to deeply equal { Object (element, content) }
    at fury.parse (/Users/marcofriso/Coding/Apiary/api-elements-js/packages/openapi2-parser/test/adapter-test.js:52:52)
    at promise.then.result (/Users/marcofriso/Coding/Apiary/api-elements-js/packages/openapi2-parser/node_modules/@apielements/core/lib/fury.js:240:30)
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:42618) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)

@kylef
Copy link
Member

kylef commented Aug 7, 2020

@marcofriso you need to commit all of the change fixtures, including the ones in packages/swagger-zoo.

@marcofriso
Copy link
Contributor Author

marcofriso commented Aug 10, 2020

@kylef I re-installed everything with yarn and regenerated the fixtures, now I see the changes in swagger-zoo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants