Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change annotation to php 8 attributes, change links to ssl, som… #1384

Open
wants to merge 19 commits into
base: 2.6
Choose a base branch
from

Conversation

Chris53897
Copy link
Contributor

…e php 8 changes

Jibbarth and others added 19 commits January 24, 2021 23:00
* [Releases] Update stable and old-stable branch

* Update releases.md

Co-authored-by: Kévin Dunglas <dunglas@gmail.com>
* Fix #2686: deprecate allow_plain_identifiers option

* fix review

* fix review

* fix review

* update example
@alanpoulain
Copy link
Member

Hello and thank you for your PR!
To reduce the burden on the maintainers, could you:

  • target 2.6 instead of main (it will avoid conflicts when we merge 2.6 into main)?
  • split your PR on multiple ones (for instance the HTTPS links and the attributes, but you can also split the attributes per page)?

@@ -62,11 +62,11 @@ For instance, if your API returns:
"hydra:member": [
{
"@id": "/books/07b90597-542e-480b-a6bf-5db223c761aa",
"@type": "http://schema.org/Book",
"@type": "https://schema.org/Book",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reverted as we currently don't support entirely the https scheme for Schema.org (both Core and the JavaScript tools must be updated to support both schemes).

Another option is to patch these toolbox cours now that both schemes are supported by the vocabulary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the requested split for https scheme in another request is a good idea. In general my opinon is that is always good to switch to https if available.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but this will cause bug in this specific case because it's a namespace, and the new namespace is currently not supported. See api-platform/schema-generator#329 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, we want to add support for the https://schema.org namespace, so we can keep this PR open until it's supported, then merge it!

@Chris53897
Copy link
Contributor Author

Hi. I will try to help as much as i can. Sorry, i thougth the SSL-Change was a no-brainer.
My main focus at the moment is api-platform/api-platform#1947
After that i try to find time to make the changes @alanpoulain suggested.

@vincentchalamon vincentchalamon changed the base branch from main to 2.6 July 20, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet