New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: change annotation to php 8 attributes, change links to ssl, som… #1384
base: 2.6
Are you sure you want to change the base?
Conversation
* [Releases] Update stable and old-stable branch * Update releases.md Co-authored-by: Kévin Dunglas <dunglas@gmail.com>
* Fix #2686: deprecate allow_plain_identifiers option * fix review * fix review * fix review * update example
Hello and thank you for your PR!
|
@@ -62,11 +62,11 @@ For instance, if your API returns: | |||
"hydra:member": [ | |||
{ | |||
"@id": "/books/07b90597-542e-480b-a6bf-5db223c761aa", | |||
"@type": "http://schema.org/Book", | |||
"@type": "https://schema.org/Book", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be reverted as we currently don't support entirely the https
scheme for Schema.org (both Core and the JavaScript tools must be updated to support both schemes).
Another option is to patch these toolbox cours now that both schemes are supported by the vocabulary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the requested split for https scheme in another request is a good idea. In general my opinon is that is always good to switch to https if available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but this will cause bug in this specific case because it's a namespace, and the new namespace is currently not supported. See api-platform/schema-generator#329 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, we want to add support for the https://schema.org
namespace, so we can keep this PR open until it's supported, then merge it!
Hi. I will try to help as much as i can. Sorry, i thougth the SSL-Change was a no-brainer. |
…e php 8 changes