Simplify deploy with docker-compose #1965
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # Uncomment line below on production server to skip docker-compose -f options | ||
| #COMPOSE_FILE=docker-compose.yml:docker-compose.prod.yml | ||
|
There was a problem hiding this comment. We should also add a default There was a problem hiding this comment. Sounds good and we can add more envs like |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
.env.distfile automatically loaded? I cannot find any information regarding this on https://docs.docker.com/compose/env-file/There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not.
Typically on repo setup,
cp .env.dist .envshould be run, and.env.distis basically an example that lives with the repo.Or you can use
--env-file .env.distas an option todocker-composecommands, although that's less nice from a UX standpoint.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case shouldn't we rename this file
.env.prodand uncomment the env var?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say that's probably appropriate considering this project's existing setup. The word
distis a bit incongruent with what this repo currently has.