feat: adapt API and lorry for grpc dbplugin #7343
Conversation
xuriwuyun
changed the title
xuriwuyun
changed the title
xuriwuyun
requested review from
ldming,
heng4fun,
free6om,
wangyelei,
Y-Rookie and
weicao
as code owners
| req.NewMemberIp = member.PodIP | ||
| } | ||
|
|
||
| _, err := mgr.dbClient.JoinMember(ctx, req) |
There was a problem hiding this comment.
The leader name may not be the real leader. And, for many databases, a replica 'join' the cluster by accessing a HA component, bot by accessing leader. ETCD and Zookeeper joins by accessing the leader, while TiDB joins by accessing PD.
There was a problem hiding this comment.
Yes, it is important to note that there may be latency in updating and obtaining the correct leader name. here lorry make its best effort to provide the available information, and the action implement should make a double check. If the provided information is not sufficient, the action implementation should consider obtaining additional information through alternative means such as service reference, and variables.
| // This field cannot be updated. | ||
| // | ||
| // +optional | ||
| GRPC *GRPCAction `json:"grpc,omitempty"` |
There was a problem hiding this comment.
As a provider, how do I know what services need to be implemented?
There was a problem hiding this comment.
en, this is the problem, and other handlers have. To ensure clarity, it is essential to explicitly address this concern at the action level in the documentation.
No description provided.