Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support upate parameters in non-default sections, e.g client or mysql: --set mysql.default-character-set = utf8mb4 (#6453) #6634

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sophon-zt
Copy link
Contributor

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (51e30e6) 66.29% compared to head (16c26ec) 66.29%.
Report is 3 commits behind head on main.

Files Patch % Lines
apis/apps/v1alpha1/configconstraint_types.go 0.00% 5 Missing ⚠️
pkg/configuration/core/config.go 91.66% 4 Missing and 1 partial ⚠️
pkg/configuration/core/reconfigure_util.go 58.33% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6634   +/-   ##
=======================================
  Coverage   66.29%   66.29%           
=======================================
  Files         303      303           
  Lines       36354    36408   +54     
=======================================
+ Hits        24101    24137   +36     
- Misses      10159    10180   +21     
+ Partials     2094     2091    -3     
Flag Coverage Δ
unittests 66.29% <80.51%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-interaction feature size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] Support upate parameters in non-default sections, e.g client or mysql
2 participants