Fixing connection cleanup in case of mass connection breaking. #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAUSE: In some cases when credentials expire, or servers encounters a blip and closes all connections. The driver gets close message on all connections. While processing those close messages, the driver was getting into race conditions, where in multiple threads were trying to close connections and trying to update the connections object i.e. list of connections in the pool. This was leading to uncaught exceptions and stale connections in the pool. These connections are never cleanedup post this. FIX: Ignore the ArrayOutOfBoundException in trying to get an object from connections object in case of creating a poolInfo message. This way, the code tries to provide the accurate poolInfo best efforts basis.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.7-dev #2600 +/- ##
=============================================
+ Coverage 76.14% 76.77% +0.62%
- Complexity 13152 13178 +26
=============================================
Files 1084 1086 +2
Lines 65160 66293 +1133
Branches 7285 7303 +18
=============================================
+ Hits 49616 50894 +1278
+ Misses 12839 12678 -161
- Partials 2705 2721 +16 ☔ View full report in Codecov by Sentry. |
spmallette
reviewed
May 15, 2024
| sb.append(c.getConnectionInfo(false)); | ||
| } catch (final ArrayIndexOutOfBoundsException ex) { |
There was a problem hiding this comment.
i mentioned this to @upadhyay-prashant elsewhere but for others looking at this, i think we want to try to handle this differently as missing logs in the event of failure might prove to be confusing when debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAUSE:
In some cases when credentials expire, or servers encounters a
blip and closes all connections. The driver gets close message on all
connections. While processing those close messages, the driver was
getting into race conditions, where in multiple threads were trying to
close connections and trying to update the connections object i.e. list
of connections in the pool. This was leading to uncaught exceptions and
stale connections in the pool. These connections are never cleanedup
post this.
FIX:
Ignore the ArrayOutOfBoundException in trying to get an object from
connections object in case of creating a poolInfo message. This way,
the code tries to provide the accurate poolInfo best efforts basis.