Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TINKERPOP-3060] Manage the versions of snappy-java and jackson-* centrally to avoid version conflict. #2546

Open
wants to merge 1 commit into
base: 3.7-dev
Choose a base branch
from

Conversation

HappyHacker123
Copy link
Contributor

Currently some modules of Tinkerpop are using the same dependency. However, some of these dependencies' versions are not centrally managed and therefore cause discrepancy. This pr defines version in parent pom.xml centrally to avoid version conflict.

@HappyHacker123
Copy link
Contributor Author

@xiazcy @Cole-Greer Could you please help me review this pr? Many thanks :)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.49%. Comparing base (9b46b67) to head (8b1e8bd).
Report is 54 commits behind head on 3.7-dev.

Additional details and impacted files
@@              Coverage Diff              @@
##             3.7-dev    #2546      +/-   ##
=============================================
+ Coverage      76.14%   76.49%   +0.34%     
- Complexity     13152    13174      +22     
=============================================
  Files           1084     1059      -25     
  Lines          65160    61282    -3878     
  Branches        7285     7297      +12     
=============================================
- Hits           49616    46876    -2740     
+ Misses         12839    11892     -947     
+ Partials        2705     2514     -191     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiazcy
Copy link
Contributor

xiazcy commented Apr 8, 2024

Thanks for the PR @HappyHacker123! I like the improvement for the dependency version management. I do want to take a closer look into other pom files that might be able to take advantage of this. Note that we are in the middle of a release so we'll hold off on any merging and I'll revisit this PR once the release is done.

@HappyHacker123
Copy link
Contributor Author

HappyHacker123 commented Apr 9, 2024

Thanks for your response :) @xiazcy .

Note that we are in the middle of a release so we'll hold off on any merging and I'll revisit this PR once the release is done.

Sure, I'm fully supportive of holding off the pr until after the release is completed :).

I do want to take a closer look into other pom files that might be able to take advantage of this.

Actually i ran a check on the whole Tinkerpop project and found many other situation like this. If you need it, i'm happy to provide the whole list :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants