THRIFT-5784: Add THeaderTransforms to TConfiguration #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
commented
May 3, 2024
Comment on lines
+458
to
+461
| // Reset writeTransforms to the ones from cfg, as we are going to add | ||
| // compression transforms from what we read, we don't want to accumulate | ||
| // different transforms read from different requests | ||
| t.writeTransforms = t.cfg.GetTHeaderTransforms() |
There was a problem hiding this comment.
a few notes here:
- in TSimpleServer we use the same THeaderProtocol instance for incoming and outgoing, while in TStandardClient we use different THeaderProtocol instances, so this behavior should only affect servers (clients would not use the THeaderProtocol read for writing)
- the consideration here (and the NOTE added in
AddTransform) is for a hypothetical scenario: if a server have a long client connection, but the long client connection is actually multiple clients (e.g. it's a proxy), and those multiple clients use different compression transforms (we currently only support zlib, but the spec also defined snappy so we might support that some day in the future), we don't want to add different compression transforms cumulatively and doing both, but just use the same compression used by the request in the response. Maybe we should markAddTransformas deprecated instead? the new feature in TConfiguration should be enough to replace that.
There was a problem hiding this comment.
Maybe we should mark AddTransform as deprecated instead?
Agreed.
There was a problem hiding this comment.
Done. Also added a real test for req and resp compression.
fishy
force-pushed
the
go-header-transform-configuration
branch
from
08c068f
to
bfe7d9a
Compare
|
@dcelasun mind taking another look? |
fishy
force-pushed
the
go-header-transform-configuration
branch
from
bfe7d9a
to
12db087
Compare
Client: go While I'm here, also auto add compression transforms read (currently only zlib is supported) to writeTransforms so that a server will auto use the same compression on the responses as the client chose to use in the requests.
fishy
force-pushed
the
go-header-transform-configuration
branch
from
12db087
to
0b5c575
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client: go
While I'm here, also auto add compression transforms read (currently only zlib is supported) to writeTransforms so that a server will auto use the same compression on the responses as the client chose to use in the requests.