Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "go: Define a bytePool for TRichTransport" #2971

Merged
merged 1 commit into from May 1, 2024
Merged

Conversation

fishy
Copy link
Member

@fishy fishy commented May 1, 2024

This reverts commit 344498b.

In our extreme case this actually made things worse. On 30s cpu profiles, although mallocgc reduced from 27.13s to 26.30s, the byte pool itself costed 11.9s. Looking at writeByte and readByte, writeByte increased from 3.69s to 5.89s, and readByte increased from 11.36s to 16.09s.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

This reverts commit 344498b.

In our extreme case this actually made things worse. On 30s cpu
profiles, although mallocgc reduced from 27.13s to 26.30s, the byte pool
itself costed 11.9s. Looking at writeByte and readByte, writeByte
increased from 3.69s to 5.89s, and readByte increased from 11.36s to
16.09s.
@fishy fishy requested a review from dcelasun May 1, 2024 16:19
@dcelasun
Copy link
Member

dcelasun commented May 1, 2024

That's a surprisingly large increase. Unfortunate :(

@fishy fishy merged commit 91d3702 into master May 1, 2024
49 of 66 checks passed
@fishy fishy deleted the revert-go-byte-pool branch May 1, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants