Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-5706: lib/cpp Fix the Security tests on openssl 1.1 and 3.0 #2940

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

THRIFT-5706: lib/cpp Fix the Security tests on openssl 1.1 and 3.0 #2940

wants to merge 2 commits into from

Commits on Feb 26, 2024

  1. THRIFT-5706: lib/cpp Fix the Security tests on openssl 1.1 and 3.0 

    This PR fixes the Security tests to build on a clean install of ubuntu
20.04 and ubuntu 22.04 without modifications to the systems openssl
configuration.

 * Enable TLS 1.0 and TLS 1.1 on OpenSSL 1.1 with the seclevel=0 flag
 * Disable TLS 1.0 and TLS 1.1 on OpenSSL 3.0

While its technically possible to enable it on OpenSSL 3 I think because
of all the issues with these old TLS versions dropping support for it is
better.

This PR builds forth on the work done here: apache#2811

Tested with the ubuntu 20.04 (OpenSSL 1.1) and 22.04 (OpenSSL 3.0) docker containers.
All lib/cpp tests succeed in both.
    @thomasbruggink
    thomasbruggink committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    8148f2f View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Enable all tests on opensslv3

    @thomasbruggink
    thomasbruggink committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    3ea763e View commit details
    Browse the repository at this point in the history