Commits on Jun 16, 2023

1. THRIFT-5706: lib: cpp: Fix C++ SecurityTest compilation on OpenSSL1.x …

   A recent change modified SecurityTest.cpp/SecurityFromBufferTest.cpp
   to handle OpenSSL3 by using OPENSSL_VERSION_MAJOR to detect the
   different OpenSSL versions. OPENSSL_VERSION_MAJOR is not available
   on OpenSSL 1.x, so these tests no longer compile on Ubuntu 20, etc.
   
   The underlying reason for the OpenSSL3 change is that older versions
   of TLS (1.0, 1.1) are only accessible when specifying @SECLEVEL=0.
   Some distributions with OpenSSL 1.1.1 (Ubuntu 20) make them accessible
   at @SECLEVEL=1, so the tests can also fail in that circumstance.
   
   This removes the reference to OPENSSL_VERSION_MAJOR and changes the
   test to specify @SECLEVEL=0 for OpenSSL versions that have @SECLEVEL
   support (> 1.1.0).
   
   Testing:
    - Tested SecurityTest/SecurityFromBufferTest on Ubuntu 20 and 22
    - Tested with OpenSSL 1.0.2

   

   joemcdonnell committed Jun 16, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for c71c999
   • Browse repository at this point

   Copy the full SHA

   c71c999 View commit details

   Browse the repository at this point in the history